(A015) [ModelicaSystem] check model executable#425
(A015) [ModelicaSystem] check model executable#425syntron wants to merge 1 commit intoOpenModelica:masterfrom
Conversation
syntron
force-pushed
the
ModelicaSystem_check_model_executable
branch
4 times, most recently
from
8b40c54 to
08056f6
Compare
syntron
force-pushed
the
ModelicaSystem_check_model_executable
branch
from
08056f6 to
6c794cb
Compare
|
Rebase. |
can but why is it needed? It is PR = one commit; should apply without problems?! |
It says, This branch has conflicts that must be resolved OMPython/ModelicaSystem.py |
…existable exists and can be executed
syntron
force-pushed
the
ModelicaSystem_check_model_executable
branch
from
6c794cb to
e5c8a41
Compare
Interesting - I did the rebase and there is no diff between the two version: |
adeas31
left a comment
adeas31
left a comment
There was a problem hiding this comment.
Would be nice to have a test for this function.
It is highly unlikely that we change model executable to not have a help command line option but just in case it would be nice to have a test for it. What do you think?
It is possible to create a separate unittests - however, each simulation request done in test_ModelicaSystem calls into this functions. Thus it is tested! Regarding a separate unittest: what should be tested? (1)a separate test if the function runs without error (=> each simulation) or (2) if the option exist (=> only possible via the execution with |
2 participants
define one fucntion to check if the model executable exists and is working
see PR #404